[webkit-reviews] review denied: [Bug 102077] Favicons are flipped in vertical direction in WinCairo builds. : [Attachment 173882] Patch

[bugzilla-daemon at webkit.org]

Brent Fulgham <bfulgham at webkit.org> has denied peavo at outlook.com's request for
review:
Bug 102077: Favicons are flipped in vertical direction in WinCairo builds.
https://bugs.webkit.org/show_bug.cgi?id=102077

Attachment 173882: Patch
https://bugs.webkit.org/attachment.cgi?id=173882&action=review

------- Additional Comments from Brent Fulgham <bfulgham at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=173882&action=review


The code changes seem reasonable, but do you have a test case that can be used
to show that it currently doesn't work, and that this change fixes it?

> Source/WebCore/platform/graphics/win/ImageCairoWin.cpp:70
> +    unsigned char *bmpdata = (unsigned char*)bmpInfo.bmBits +
bmpInfo.bmWidthBytes*(bmpInfo.bmHeight-1);

This should be declared "unsigned char*"