[webkit-reviews] review granted: [Bug 102348] [V8] Remove IsSubType() from CodeGeneratorV8.pm : [Attachment 174367] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Nov 15 08:53:59 PST 2012


Adam Barth <abarth at webkit.org> has granted Kentaro Hara
<haraken at chromium.org>'s request for review:
Bug 102348: [V8] Remove IsSubType() from CodeGeneratorV8.pm
https://bugs.webkit.org/show_bug.cgi?id=102348

Attachment 174367: Patch
https://bugs.webkit.org/attachment.cgi?id=174367&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=174367&action=review


> Source/WebCore/bindings/scripts/CodeGeneratorJS.pm:1422
> -    my $eventTarget = $dataNode->extendedAttributes->{"EventTarget"} ||
$codeGenerator->IsStrictSubtype($dataNode, "EventTarget");
> +    my $eventTarget = $dataNode->extendedAttributes->{"EventTarget"} ||
$codeGenerator->IsStrictSubType($dataNode, "EventTarget");

Why not change this to call IsSubType since it's using that pattern anyway?


More information about the webkit-reviews mailing list