[webkit-reviews] review denied: [Bug 99447] [GTK] Guard GTK specific members in GeolocationProviderGeoclue class for the common use. : [Attachment 174355] Patch

[bugzilla-daemon at webkit.org]

Martin Robinson <mrobinson at webkit.org> has denied Byungwoo Lee
<bw80.lee at samsung.com>'s request for review:
Bug 99447: [GTK] Guard GTK specific members in GeolocationProviderGeoclue class
for the common use.
https://bugs.webkit.org/show_bug.cgi?id=99447

Attachment 174355: Patch
https://bugs.webkit.org/attachment.cgi?id=174355&action=review

------- Additional Comments from Martin Robinson <mrobinson at webkit.org>
I'm not sure this patch makes sense. GeolocationProviderGeoclue is a geoclue
implementation of a geolocation provider. Geoclue is a library that depends on
using GLib. There's nothing specific to GTK+ in this file that I can see. If
you want to make a geolocation provider that doesn't use Geoclue (and by
exetension GLib), then you should make an entirely new provider.

I'm also curious about the direction this is moving. Is the EFL port trying to
remove all GLib dependencies? That would require switching to the cURL
networking back-end, for instance.