[webkit-reviews] review denied: [Bug 101910] Web Inspector: line number of script should be search-able in Timeline Panel : [Attachment 174369] Patch

[bugzilla-daemon at webkit.org]

Pavel Feldman <pfeldman at chromium.org> has denied pdeng6 <pan.deng at intel.com>'s
request for review:
Bug 101910: Web Inspector: line number of script should be search-able in
Timeline Panel
https://bugs.webkit.org/show_bug.cgi?id=101910

Attachment 174369: Patch
https://bugs.webkit.org/attachment.cgi?id=174369&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=174369&action=review


> Source/WebCore/inspector/front-end/TimelinePresentationModel.js:888
> +		      
contentHelper._appendTextRow(WebInspector.UIString("Details"),
this.detailsNode().childNodes[1].textContent);

So this is a third time I am suggesting to call appendElementRow here :) Is
there a reason why this is bad?

> Source/WebCore/inspector/front-end/TimelinePresentationModel.js:1006
> +	   if (!details)

You don't need this check now.