[webkit-reviews] review granted: [Bug 102357] Remove Node::aboutToUnload and be more explicit about what it was for : [Attachment 174390] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Nov 15 03:27:48 PST 2012
Ryosuke Niwa <rniwa at webkit.org> has granted Elliott Sprehn
<esprehn at chromium.org>'s request for review:
Bug 102357: Remove Node::aboutToUnload and be more explicit about what it was
for
https://bugs.webkit.org/show_bug.cgi?id=102357
Attachment 174390: Patch
https://bugs.webkit.org/attachment.cgi?id=174390&action=review
------- Additional Comments from Ryosuke Niwa <rniwa at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=174390&action=review
> Source/WebCore/ChangeLog:14
> + No new tests, this is just a refactor.
refactoring?
> Source/WebCore/loader/FrameLoader.cpp:395
> + if (currentFocusedNode &&
currentFocusedNode->toInputElement())
It's probably better if we had a local variable to avoid calling toInputElement
twice.
More information about the webkit-reviews
mailing list