[webkit-reviews] review granted: [Bug 102040] [Chromium] Add tests for month suggestion picker : [Attachment 174352] Patch

[bugzilla-daemon at webkit.org]

Kent Tamura <tkent at chromium.org> has granted Keishi Hattori
<keishi at webkit.org>'s request for review:
Bug 102040: [Chromium] Add tests for month suggestion picker
https://bugs.webkit.org/show_bug.cgi?id=102040

Attachment 174352: Patch
https://bugs.webkit.org/attachment.cgi?id=174352&action=review

------- Additional Comments from Kent Tamura <tkent at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=174352&action=review


> LayoutTests/platform/chromium/TestExpectations:2828
>  

Maybe you want to add month-suggestion-picker-key-operations.html too because
of F4 difference?

>
LayoutTests/platform/chromium/fast/forms/suggestion-picker/month-suggestion-pic
ker-key-operations.html:89
> +    shouldBe('popupWindow.pagePopupController.toString()', '"[object
PagePopupController]"');

nit: shouldBeEqualToString is better because we can avoid nested quotes.

>
LayoutTests/platform/chromium/fast/forms/suggestion-picker/month-suggestion-pic
ker-key-operations.html:95
> +    shouldBe('highlightedEntry()', '"2012-01"');

ditto.