[webkit-reviews] review granted: [Bug 102159] [chromium] Clamp negative sizes to zero when converting to gfx:: types : [Attachment 174310] Patch

[bugzilla-daemon at webkit.org]

James Robinson <jamesr at chromium.org> has granted Dana Jansens
<danakj at chromium.org>'s request for review:
Bug 102159: [chromium] Clamp negative sizes to zero when converting to gfx::
types
https://bugs.webkit.org/show_bug.cgi?id=102159

Attachment 174310: Patch
https://bugs.webkit.org/attachment.cgi?id=174310&action=review

------- Additional Comments from James Robinson <jamesr at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=174310&action=review


OK, thanks for the history.  Seems reasonable except for the build failure.

> Source/Platform/chromium/public/WebFloatRect.h:111
> +	   return gfx::RectF(x, y, std::max(0, width), std::max(0, height));

gonna need to use floating point literals or invoke the ::max() override you
want with max<float>, i think