[webkit-reviews] review granted: [Bug 102287] Refactor ViewportArguments to only use CSS units : [Attachment 174264] Patch

[bugzilla-daemon at webkit.org]

Noam Rosenthal <noam at webkit.org> has granted Kenneth Rohde Christiansen
<kenneth at webkit.org>'s request for review:
Bug 102287: Refactor ViewportArguments to only use CSS units
https://bugs.webkit.org/show_bug.cgi?id=102287

Attachment 174264: Patch
https://bugs.webkit.org/attachment.cgi?id=174264&action=review

------- Additional Comments from Noam Rosenthal <noam at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=174264&action=review


> Source/WebCore/dom/ViewportArguments.cpp:46
> +static inline float clampLengthValue(float value)

how about clampLengthValueToSpecDefinedRange? Or otherwise mention in a comment
that the "magic numbers" come from the spec, and put a link to the spec.