[webkit-reviews] review granted: [Bug 102297] [V8] We can shave one instruction off toV8Fast : [Attachment 174281] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Nov 14 16:22:55 PST 2012


Kentaro Hara <haraken at chromium.org> has granted Adam Barth
<abarth at webkit.org>'s request for review:
Bug 102297: [V8] We can shave one instruction off toV8Fast
https://bugs.webkit.org/show_bug.cgi?id=102297

Attachment 174281: Patch
https://bugs.webkit.org/attachment.cgi?id=174281&action=review

------- Additional Comments from Kentaro Hara <haraken at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=174281&action=review


> Source/WebCore/ChangeLog:8
> +	   There's no reason to store info.Holder in a local variable. Calling

Just in case, would you check the performance in Bindings/first-child.html ? In
the DOM binding benchmark suite in v8-internal (which is a super micro
benchmark), info.Holder() is not free.


More information about the webkit-reviews mailing list