[webkit-reviews] review granted: [Bug 96818] Add tests for explicit serialization values : [Attachment 174253] Patch

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has granted Alec Flett
<alecflett at chromium.org>'s request for review:
Bug 96818: Add tests for explicit serialization values
https://bugs.webkit.org/show_bug.cgi?id=96818

Attachment 174253: Patch
https://bugs.webkit.org/attachment.cgi?id=174253&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=174253&action=review


> Source/WebCore/bindings/js/SerializedScriptValue.h:88
>      String toString();
> +    String toWireString() { return toString(); }

What's the difference between toString and toWireString?  Should we add a
comment explaining the difference?

> LayoutTests/platform/chromium/fast/storage/serialized-script-value.html:8
> +    expectedV = expectedValues;

expectedV <--- "V" isn't a great part of a variable name.  we prefer complete
words in variable names.