[webkit-reviews] review granted: [Bug 101883] [TexMap][Cairo] Accelerated compositing debug visuals : [Attachment 173539] Patch

[bugzilla-daemon at webkit.org]

Martin Robinson <mrobinson at webkit.org> has granted Helder Correia
<helder.correia at nokia.com>'s request for review:
Bug 101883: [TexMap][Cairo] Accelerated compositing debug visuals
https://bugs.webkit.org/show_bug.cgi?id=101883

Attachment 173539: Patch
https://bugs.webkit.org/attachment.cgi?id=173539&action=review

------- Additional Comments from Martin Robinson <mrobinson at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=173539&action=review


Looks sane to me.

>> Source/WebCore/platform/graphics/texmap/TextureMapperGL.cpp:365
>> +	cairo_set_source_rgb(cr, 1, 0, 0);
> 
> Qt has comment about blue color that it will turn red because R+B are not
swapped. 
> Will it result blue or red here? If it will result in different color from
specified, IMHO, it requires comment here.

You probably want to do the same thing as Qt above here.

> Source/WebCore/platform/graphics/texmap/TextureMapperGL.cpp:372
> +    cairo_move_to(cr, 2, pointSize);

Is this 2 pixels just padding?