[webkit-reviews] review granted: [Bug 102183] REGRESSION(r134495): It made svg/custom/use-instanceRoot-event-listeners.xhtml fail and fast/events/attribute-listener-deletion-crash.html timeout : [Attachment 174248] A more appropriate fix.

[bugzilla-daemon at webkit.org]

Geoffrey Garen <ggaren at apple.com> has granted Mark Lam <mark.lam at apple.com>'s
request for review:
Bug 102183: REGRESSION(r134495): It made
svg/custom/use-instanceRoot-event-listeners.xhtml fail and
fast/events/attribute-listener-deletion-crash.html timeout
https://bugs.webkit.org/show_bug.cgi?id=102183

Attachment 174248: A more appropriate fix.
https://bugs.webkit.org/attachment.cgi?id=174248&action=review

------- Additional Comments from Geoffrey Garen <ggaren at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=174248&action=review


r=me

> Source/WebCore/bindings/js/JSEventListener.cpp:169
> +	   // accessed. m_jsFunction should effectively be 0 in that case.
> +	   JSC::JSObject* jsFunction = m_wrapper ? m_jsFunction.get() : 0;

The duplication of this functionality and commentary suggests that a helper
function is in order. I won't require that here since you've posted a follow-up
patch that obsoletes this code.