[webkit-reviews] review denied: [Bug 96818] Add tests for explicit serialization values : [Attachment 174195] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Nov 14 11:27:40 PST 2012


Adam Barth <abarth at webkit.org> has denied Alec Flett <alecflett at chromium.org>'s
request for review:
Bug 96818: Add tests for explicit serialization values
https://bugs.webkit.org/show_bug.cgi?id=96818

Attachment 174195: Patch
https://bugs.webkit.org/attachment.cgi?id=174195&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
Woah, I don't think we want to link in the internals object into the unit
tests.	If you want to use internals, you should write a LayoutTest (perhaps
somewhere in the platform/chromium directory).	If you want to write a unit
test, you should just call WebSerializedScriptValue::serialize and
WebSerializedScriptValue::fromString directly from the unit test.  Note: You
can use WebFrame::executeScriptAndReturnValue to create interesting JavaScript
objects to serialize.


More information about the webkit-reviews mailing list