[webkit-reviews] review denied: [Bug 87905] Can avoid a second layout of flex-items in some cases : [Attachment 174091] Patch

[bugzilla-daemon at webkit.org]

Tony Chang <tony at chromium.org> has denied Carlos Garcia Campos
<cgarcia at igalia.com>'s request for review:
Bug 87905: Can avoid a second layout of flex-items in some cases
https://bugs.webkit.org/show_bug.cgi?id=87905

Attachment 174091: Patch
https://bugs.webkit.org/attachment.cgi?id=174091&action=review

------- Additional Comments from Tony Chang <tony at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=174091&action=review


> Source/WebCore/rendering/RenderFlexibleBox.cpp:1090
> +	   LayoutUnit childCurrentSize = isColumnFlow() ?
child->logicalHeight() : child->logicalWidth();

You want mainAxisExtentForChild().  You don't want the child's logical height
since it can have an orthogonal writing mode to the flexbox.