[webkit-reviews] review denied: [Bug 102236] [BlackBerry] Use mispelled-marker offsets relative to the element : [Attachment 174159] Patch

[bugzilla-daemon at webkit.org]

Rob Buis <rwlbuis at gmail.com> has denied Nima Ghanavatian
<nima.ghanavatian at gmail.com>'s request for review:
Bug 102236: [BlackBerry] Use mispelled-marker offsets relative to the element
https://bugs.webkit.org/show_bug.cgi?id=102236

Attachment 174159: Patch
https://bugs.webkit.org/attachment.cgi?id=174159&action=review

------- Additional Comments from Rob Buis <rwlbuis at gmail.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=174159&action=review


Looks good but style errors need to be fixed.

> Source/WebKit/blackberry/WebKitSupport/InputHandler.cpp:759
> +    VisiblePosition caretPosition =
m_currentFocusElement->document()->frame()->selection()->selection().visibleSta
rt();

Scary. Also selection().selection() looks weird.

>> Source/WebKit/blackberry/WebKitSupport/InputHandler.cpp:763
>> +	if (!rangeSelection)
> 
> Omit int when using unsigned	[runtime/unsigned] [1]

Style queue bug? I assume it means the unsigned int below....
This is the second time in a week we are hitting style queue problems. Doesn't
it like our IMF code? :)

> Source/WebKit/blackberry/WebKitSupport/InputHandler.cpp:767
> +    unsigned int length = 0;

I think the warnings are about these lines.