[webkit-reviews] review denied: [Bug 101905] Web Inspector: use last selection as complementary signal when applying DOM changes to the text model. : [Attachment 173921] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Nov 14 01:31:42 PST 2012
Vsevolod Vlasov <vsevik at chromium.org> has denied Pavel Feldman
<pfeldman at chromium.org>'s request for review:
Bug 101905: Web Inspector: use last selection as complementary signal when
applying DOM changes to the text model.
https://bugs.webkit.org/show_bug.cgi?id=101905
Attachment 173921: Patch
https://bugs.webkit.org/attachment.cgi?id=173921&action=review
------- Additional Comments from Vsevolod Vlasov <vsevik at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=173921&action=review
> Source/WebCore/inspector/front-end/DefaultTextEditor.js:473
> + return this._mainPanel._lastSelection;
There are still some _lastSelection usages in editor, r- for that.
> Source/WebCore/inspector/front-end/DefaultTextEditor.js:2153
> + var isBackspace = this._keyDownCode ===
WebInspector.KeyboardShortcut.Keys.Backspace.code;
Delete?
> Source/WebCore/inspector/front-end/DefaultTextEditor.js:2165
> + var range = this._lastSelection.clone();
backwards selection?
More information about the webkit-reviews
mailing list