[webkit-reviews] review denied: [Bug 100114] Web Inspector: Timeline: nest time/timeEnd records when possible (in glue-mode) : [Attachment 173004] Patch

[bugzilla-daemon at webkit.org]

Pavel Feldman <pfeldman at chromium.org> has denied eustas.bug at gmail.com's request
for review:
Bug 100114: Web Inspector: Timeline: nest time/timeEnd records when possible
(in glue-mode)
https://bugs.webkit.org/show_bug.cgi?id=100114

Attachment 173004: Patch
https://bugs.webkit.org/attachment.cgi?id=173004&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=173004&action=review


> Source/WebCore/inspector/front-end/TimelinePresentationModel.js:602
> +		  
openRecord.children.splice(insertionIndexForObjectInListSortedByFunction(timeRe
cord.startTime, openRecord.children, compareStartTime), 0, timeRecord);

We only glue causation. I.e. we can glue TimerFire to TimerInstall. We can't
glue timeEnd to anything, because it already has a parent. The rules for
glueing should stay simple.