[webkit-reviews] review granted: [Bug 101327] [Qt][WTR] TestController::platformRunUntil should not do busy waiting : [Attachment 173599] Patch

[bugzilla-daemon at webkit.org]

Simon Hausmann <hausmann at webkit.org> has granted Balazs Kelemen
<kbalazs at webkit.org>'s request for review:
Bug 101327: [Qt][WTR] TestController::platformRunUntil should not do busy
waiting
https://bugs.webkit.org/show_bug.cgi?id=101327

Attachment 173599: Patch
https://bugs.webkit.org/attachment.cgi?id=173599&action=review

------- Additional Comments from Simon Hausmann <hausmann at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=173599&action=review


> Tools/WebKitTestRunner/qt/TestControllerQt.cpp:62
> +    QTimer timer;

This could also be implemented using a QBasicTimer, removing the need for
Q_OBJECT and moc inclusion.

> Tools/WebKitTestRunner/qt/TestControllerQt.cpp:67
> +Q_GLOBAL_STATIC(RunLoopContext, g_loopContext);

I still think that it would be cleaner if this was a member variable of
TestController instead.