[webkit-reviews] review denied: [Bug 101334] Web Inspector: Timeline: 'undefined' javascript filenames. : [Attachment 174082] Patch

[bugzilla-daemon at webkit.org]

Pavel Feldman <pfeldman at chromium.org> has denied eustas.bug at gmail.com's request
for review:
Bug 101334: Web Inspector: Timeline: 'undefined' javascript filenames.
https://bugs.webkit.org/show_bug.cgi?id=101334

Attachment 174082: Patch
https://bugs.webkit.org/attachment.cgi?id=174082&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=174082&action=review


>
LayoutTests/inspector/timeline/timeline-timer-fired-from-eval-call-site.html:24

> +	   InspectorTest.evaluateInPage("performActions()");

You should use named function start here as you have finish below.

>
LayoutTests/inspector/timeline/timeline-timer-fired-from-eval-call-site.html:30

> +	   function formatter(record) {

{ on the next line

>
LayoutTests/inspector/timeline/timeline-timer-fired-from-eval-call-site.html:42

> +    setTimeout(performActions, 3000);

Never use setTimeout in tests. Do this from within startTimeline callback