[webkit-reviews] review granted: [Bug 101512] Move empty loading to DocumentLoader, simplify FrameLoader::init() : [Attachment 174010] patch #2

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has granted Nate Chapin <japhet at chromium.org>'s
request for review:
Bug 101512: Move empty loading to DocumentLoader, simplify FrameLoader::init()
https://bugs.webkit.org/show_bug.cgi?id=101512

Attachment 174010: patch #2
https://bugs.webkit.org/attachment.cgi?id=174010&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=174010&action=review


Overall, I think this patch is worth doing.  The improvement to
FrameLoader::init is really compelling.  The more stuff we do in init, the more
code has to be aware of its not-quite-consistent states.

> Source/WebCore/loader/MainResourceLoader.cpp:631
> +    willSendRequest(request, ResourceResponse());

I see.	This feels a bit sub-optimal.