[webkit-reviews] review denied: [Bug 98007] A Spin button should release mouse event capturing when a modal dialog opens : [Attachment 174066] Patch 2

[bugzilla-daemon at webkit.org]

Kent Tamura <tkent at chromium.org> has denied Kent Tamura <tkent at chromium.org>'s
request for review:
Bug 98007: A Spin button should release mouse event capturing when a modal
dialog opens
https://bugs.webkit.org/show_bug.cgi?id=98007

Attachment 174066: Patch 2
https://bugs.webkit.org/attachment.cgi?id=174066&action=review

------- Additional Comments from Kent Tamura <tkent at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=174066&action=review


>> Source/WebCore/dom/Node.h:125
>> +class Node : public EventTarget, public ScriptWrappable, public
TreeShared<Node, ContainerNode>, public PopupOpeningObserver {
> 
> Yeah, this will increase sizeof(Node) by 8 byte, which wouldn't be
acceptable.
> 
> A virtual function table pointer is needed for each multiply-inherited class
that has virtual functions. Currently only EventTarget has virtual functions
and thus each Node has only one virtual function table pointer. If you add
PopupOpeningObserver, which has virtual functions, it will add one more virtual
function table pointer to each Node.

I see.	I'll update the patch so that I don't change Node parents.