[webkit-reviews] review requested: [Bug 101989] JSC: JSEventListener's m_jsFunction should be a weak ref : [Attachment 174061] Fix.

[bugzilla-daemon at webkit.org]

Mark Lam <mark.lam at apple.com> has asked  for review:
Bug 101989: JSC: JSEventListener's m_jsFunction should be a weak ref
https://bugs.webkit.org/show_bug.cgi?id=101989

Attachment 174061: Fix.
https://bugs.webkit.org/attachment.cgi?id=174061&action=review

------- Additional Comments from Mark Lam <mark.lam at apple.com>
All the issues that Geoff pointed out has been addressed.  The website
rendering issue turned out to be because the Weak implementation did not have
an operation==() implementation.  As a result, when we changed m_jsFunction to
be a Weak ref, JSEventListener::operator==() (which was comparing
m_jsFunctions) was getting the wrong result.  This is now fixed by providing an
implementation of operator==(const Weak<T>&, const Weak<T>&).