[webkit-reviews] review denied: [Bug 101458] Fix compile warning [-Wsign-compare] : [Attachment 174031] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Nov 13 19:38:27 PST 2012


Alexey Proskuryakov <ap at webkit.org> has denied KyungTae Kim
<ktf.kim at samsung.com>'s request for review:
Bug 101458: Fix compile warning [-Wsign-compare]
https://bugs.webkit.org/show_bug.cgi?id=101458

Attachment 174031: Patch
https://bugs.webkit.org/attachment.cgi?id=174031&action=review

------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
I think that this is the right fix. You can consider adding an assertion that
st_size is non-negative.

Please fix coding style though - we prefer C++ style casts (static_cast).


More information about the webkit-reviews mailing list