[webkit-reviews] review granted: [Bug 102152] PDFPlugin should support downloading PDFs : [Attachment 174032] patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Nov 13 19:02:28 PST 2012


Alexey Proskuryakov <ap at webkit.org> has granted Tim Horton
<timothy_horton at apple.com>'s request for review:
Bug 102152: PDFPlugin should support downloading PDFs
https://bugs.webkit.org/show_bug.cgi?id=102152

Attachment 174032: patch
https://bugs.webkit.org/attachment.cgi?id=174032&action=review

------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=174032&action=review


> Source/WebKit2/UIProcess/WebPageProxy.cpp:4102
> +    if (mimeType != "application/pdf")
> +	   return;

I'm not sure about the value of this check (and the argument, which is just
hardcoded on the other side anyway).


More information about the webkit-reviews mailing list