[webkit-reviews] review granted: [Bug 102120] Move inline style logic from ElementAttributeData to StyledElement. : [Attachment 173959] Meh patch

[bugzilla-daemon at webkit.org]

Antti Koivisto <koivisto at iki.fi> has granted Andreas Kling <kling at webkit.org>'s
request for review:
Bug 102120: Move inline style logic from ElementAttributeData to StyledElement.
https://bugs.webkit.org/show_bug.cgi?id=102120

Attachment 173959: Meh patch
https://bugs.webkit.org/attachment.cgi?id=173959&action=review

------- Additional Comments from Antti Koivisto <koivisto at iki.fi>
View in context: https://bugs.webkit.org/attachment.cgi?id=173959&action=review


> Source/WebCore/dom/StyledElement.cpp:146
> +    // For some reason, we allow CSSOM wrappers for inline style
declarations to outlive the element.
> +    if (PropertySetCSSStyleDeclaration* cssomWrapper =
inlineStyleCSSOMWrapper())
> +	   cssomWrapper->clearParentElement();

The comment doesn't seem that helpful. Do you mean that the wrapper should keep
the element alive?

> Source/WebCore/dom/StyledElement.cpp:151
> -    return ensureInlineStyle()->ensureInlineCSSStyleDeclaration(this);
> +    return
ensureMutableInlineStyle()->ensureInlineCSSStyleDeclaration(this);

Would be good to move the wrapper ownership to StyledElement too at some point.
The current propertySetCSSOMWrapperMap hackery is silly.