[webkit-reviews] review granted: [Bug 102132] Update DOMException name: NoDataAllowedError : [Attachment 173980] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Erik Arvidsson <arv at chromium.org>'s
request for review:
Bug 102132: Update DOMException name: NoDataAllowedError
https://bugs.webkit.org/show_bug.cgi?id=102132

Attachment 173980: Patch
https://bugs.webkit.org/attachment.cgi?id=173980&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=173980&action=review


> Source/WebCore/dom/ExceptionCode.h:39
> +	   NO_DATA_ALLOWED_ERR = 6, // Historical

That’s a confusing comment. "Not used in any spec or in our code" would be a
better comment. And we should consider removing the constant entirely at some
point.