[webkit-reviews] review requested: [Bug 101512] Move empty loading to DocumentLoader, simplify FrameLoader::init() : [Attachment 174010] patch #2

[bugzilla-daemon at webkit.org]

Nate Chapin <japhet at chromium.org> has asked  for review:
Bug 101512: Move empty loading to DocumentLoader, simplify FrameLoader::init()
https://bugs.webkit.org/show_bug.cgi?id=101512

Attachment 174010: patch #2
https://bugs.webkit.org/attachment.cgi?id=174010&action=review

------- Additional Comments from Nate Chapin <japhet at chromium.org>
I got the mac crash to repro some locally, and it appears it was related to
willSendRequest() nulling out a ResourceRequest for a main resource. 
Currently, willSendRequest() null the ResourceRequest functins exactly the same
as an empty url getting passed in from the beginning.  I can think of three
ways to resolve this:

1. Call willSendRequest() from startLoadingMainResource() for the initial load,
rather than in MainResourceLoader.
2. Check whether willSendRequest() cancelled the load in MainResourceLoader,
and fallback to empty loading in DocumentLoader.
3. Keep empty loading back to MainResourceLoader, scrapping the
FrameLoader::init() cleanup.

This patch implements #2.  It seems ok, but it's not quite as clean as I was
hoping.