[webkit-reviews] review denied: [Bug 102007] webkitpy: consolidate webkit-base-finding code : [Attachment 173770] add missed tests

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Nov 13 13:05:06 PST 2012


Eric Seidel <eric at webkit.org> has denied Dirk Pranke <dpranke at chromium.org>'s
request for review:
Bug 102007: webkitpy: consolidate webkit-base-finding code
https://bugs.webkit.org/show_bug.cgi?id=102007

Attachment 173770: add missed tests
https://bugs.webkit.org/attachment.cgi?id=173770&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
SystemHost currently ahs nothing to do with WebKit.  it's simply a mock-point
for writing python code which can be easily mocked.  I dont' think this is the
right direction.  I do support consolidating this logic. But SystemHost is the
wrong place IMO.


More information about the webkit-reviews mailing list