[webkit-reviews] review granted: [Bug 101263] AX: MathML types need to be semantically identified in AX tree : [Attachment 172447] patch

[bugzilla-daemon at webkit.org]

Beth Dakin <bdakin at apple.com> has granted chris fleizach
<cfleizach at apple.com>'s request for review:
Bug 101263: AX: MathML types need to be semantically identified in AX tree
https://bugs.webkit.org/show_bug.cgi?id=101263

Attachment 172447: patch
https://bugs.webkit.org/attachment.cgi?id=172447&action=review

------- Additional Comments from Beth Dakin <bdakin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=172447&action=review


> Source/WebCore/accessibility/AccessibilityRenderObject.cpp:3548
> +    if (node()->hasTagName(MathMLNames::munderTag) ||
node()->hasTagName(MathMLNames::munderoverTag))

Do you need to null-check node() here?

> Source/WebCore/accessibility/AccessibilityRenderObject.cpp:3563
> +    if (node()->hasTagName(MathMLNames::moverTag))

Do you need to null-check node() here?

> Source/WebCore/accessibility/AccessibilityRenderObject.cpp:3593
> +    if (node()->hasTagName(MathMLNames::msubTag) ||
node()->hasTagName(MathMLNames::msubsupTag))

Do you need to null-check node() here?

> Source/WebCore/accessibility/AccessibilityRenderObject.cpp:3608
> +    if (node()->hasTagName(MathMLNames::msupTag))

Do you need to null-check node() here?