[webkit-reviews] review granted: [Bug 102102] Add DOMRequestState to maintain world/ScriptExecutionContext state : [Attachment 173940] Patch

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has granted  review:
Bug 102102: Add DOMRequestState to maintain world/ScriptExecutionContext state
https://bugs.webkit.org/show_bug.cgi?id=102102

Attachment 173940: Patch
https://bugs.webkit.org/attachment.cgi?id=173940&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=173940&action=review


> Source/WebCore/bindings/v8/DOMRequestState.h:48
> +	       : m_contextScope(state.context()) { }

The { and } should each be on their own line.

> Source/WebCore/bindings/v8/DOMRequestState.h:61
> +    ScriptExecutionContext* m_scriptExecutionContext;

How does this pointer get cleared when the ScriptExecutionContext is destroyed?
 Maybe we should clear it explicitly in IDBRequest::stop.