[webkit-reviews] review denied: [Bug 102000] [EFL][WK2] White flicker when scrolling big pages with dark background on slower hardware. : [Attachment 173926] Updated patch.

[bugzilla-daemon at webkit.org]

Noam Rosenthal <noam at webkit.org> has denied Viatcheslav Ostapenko
<ostap73 at gmail.com>'s request for review:
Bug 102000: [EFL][WK2] White flicker when scrolling big pages with dark
background on slower hardware.
https://bugs.webkit.org/show_bug.cgi?id=102000

Attachment 173926: Updated patch.
https://bugs.webkit.org/attachment.cgi?id=173926&action=review

------- Additional Comments from Noam Rosenthal <noam at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=173926&action=review


> Source/WebCore/platform/graphics/texmap/TextureMapperGL.cpp:432
> +    FloatRect targetRect(0, 0, data().viewport[2], data().viewport[3]);
> +    drawQuad(targetRect, TransformationMatrix(), program.get(),
GraphicsContext3D::TRIANGLE_FAN, false);

Clearing the whole viewport doesn't make sense. We should expose
drawSolidColor(const FloatRect&, const TransformationMatrix&, const Color&),
and pass in the viewport rect from LayerTreeRenderer.

> Source/WebKit2/ChangeLog:38
> +	   (WebKit::LayerTreeRenderer::enableViewBackgroundMatchToPage):

Let's change this to setDrawsBackground