[webkit-reviews] review granted: [Bug 101634] Sever Chromium's dependence on WebKitSystemInterface media control drawing functions in RenderThemeMac : [Attachment 173677] RenderThemeMacShared, v1

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has granted Robert Sesek <rsesek at chromium.org>'s
request for review:
Bug 101634: Sever Chromium's dependence on WebKitSystemInterface media control
drawing functions in RenderThemeMac
https://bugs.webkit.org/show_bug.cgi?id=101634

Attachment 173677: RenderThemeMacShared,v1
https://bugs.webkit.org/attachment.cgi?id=173677&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=173677&action=review


I didn't verify that you've moved all this code identically, but the overall
shape of this change looks like it matches what mjs asked for.

> Source/WebCore/rendering/RenderThemeMac.mm:56
> +    : RenderThemeMacShared()

Do you need to explicitly call the base class constructor?  Usually the
compiler will do that for you.

> Source/WebCore/rendering/RenderThemeMacShared.h:30
> +

Looks like you've got an extra blank line here.

> Source/WebCore/rendering/RenderThemeMacShared.mm:67
> +

Here too