[webkit-reviews] review granted: [Bug 101974] Boxes with rounded corners and thin borders are too slow to draw : [Attachment 173887] Patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted Justin Novosad
<junov at google.com>'s request for review:
Bug 101974: Boxes with rounded corners and thin borders are too slow to draw
https://bugs.webkit.org/show_bug.cgi?id=101974

Attachment 173887: Patch
https://bugs.webkit.org/attachment.cgi?id=173887&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=173887&action=review


> Source/WebCore/ChangeLog:9
> +	   With the current implementation RenderBox::
> +	   determineBackgroundBleedAvoidance() the slow path

I think you're missing a 'uses'

> Source/WebCore/ChangeLog:12
> +	   borders.  This is because the BackgroundBleedShrinkBackground

One space after periods.

> Source/WebCore/ChangeLog:18
> +	   By using this approach rater than
BackgroundBleedUseTransparencyLayer,

rather

> Source/WebCore/rendering/RenderBox.cpp:897
> +bool RenderBox::backgroundIsSingleOpaqueLayer() const

Multiple sold color backgrounds would also be OK, no?

> Source/WebCore/rendering/RenderBoxModelObject.cpp:703
> +    adjustedRect.inflateY(-static_cast<LayoutUnit>(ceil(1 /
transform.yScale())));	  

Whitespace at EOL?

> Source/WebCore/rendering/RenderBoxModelObject.cpp:713
> +	   adjustedRect.inflateX(-static_cast<LayoutUnit>(ceil(1 /
transform.xScale())));

We should probably provide a helper function for this shrinking.

> LayoutTests/ChangeLog:12
> +	   * fast/borders/border-radius-wide-border-05.html: Added.

Where's the pixel result?

> LayoutTests/fast/borders/border-radius-wide-border-05.html:11
> +	   -moz-box-sizing: border-box;

Remove.