[webkit-reviews] review granted: [Bug 101907] Web Inspector: Extract common interface for StatusBarButton and StatusBarCombo : [Attachment 173610] Patch

[bugzilla-daemon at webkit.org]

Pavel Feldman <pfeldman at chromium.org> has granted eustas.bug at gmail.com's
request for review:
Bug 101907: Web Inspector: Extract common interface for StatusBarButton and
StatusBarCombo
https://bugs.webkit.org/show_bug.cgi?id=101907

Attachment 173610: Patch
https://bugs.webkit.org/attachment.cgi?id=173610&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=173610&action=review


> Source/WebCore/inspector/front-end/StatusBarButton.js:32
>   * @extends {WebInspector.Object}

@constructor should go first (we use alphabetic order)

> Source/WebCore/inspector/front-end/StatusBarButton.js:34
> + * @param {!Element} element

We don't use ! notation

> Source/WebCore/inspector/front-end/StatusBarButton.js:46
> +    setEnabled: function(value) {

{ on the next line

> Source/WebCore/inspector/front-end/StatusBarButton.js:58
> + * @constructor

ditto

> Source/WebCore/inspector/front-end/StatusBarButton.js:272
> + * @extends {WebInspector.StatusBarItem}

ditto

> Source/WebCore/inspector/front-end/StatusBarButton.js:291
> +	* @param {!Element} option

ditto

> Source/WebCore/inspector/front-end/StatusBarButton.js:301
> +    setEnabled: function(value)

Hm. This looks like copy-paste, but I don't have a good suggestion for you :(