[webkit-reviews] review denied: [Bug 101929] Web Inspector: Sources: Scope Variables: add "Add to watch" menu item. : [Attachment 173630] Patch

[bugzilla-daemon at webkit.org]

Yury Semikhatsky <yurys at chromium.org> has denied eustas.bug at gmail.com's request
for review:
Bug 101929: Web Inspector: Sources: Scope Variables: add "Add to watch" menu
item.
https://bugs.webkit.org/show_bug.cgi?id=101929

Attachment 173630: Patch
https://bugs.webkit.org/attachment.cgi?id=173630&action=review

------- Additional Comments from Yury Semikhatsky <yurys at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=173630&action=review


> Source/WebCore/inspector/front-end/ScopeChainSidebarPane.js:175
> +    _onContextMenu: function(event) {

_onContextMenu -> _onNameContextMenu ?

> Source/WebCore/inspector/front-end/ScopeChainSidebarPane.js:193
> +	   for (var i = 1; i < path.length; ++i) {

There may also be local variables like [[boundThis]] and <exception> which we
shouldn't allow to add to watches.