[webkit-reviews] review granted: [Bug 102048] Unable to set valid time value to input[type=time] with user interaction in some cases : [Attachment 173824] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Nov 12 22:59:16 PST 2012


Kentaro Hara <haraken at chromium.org> has granted Kent Tamura
<tkent at chromium.org>'s request for review:
Bug 102048: Unable to set valid time value to input[type=time] with user
interaction in some cases
https://bugs.webkit.org/show_bug.cgi?id=102048

Attachment 173824: Patch
https://bugs.webkit.org/attachment.cgi?id=173824&action=review

------- Additional Comments from Kentaro Hara <haraken at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=173824&action=review


> Source/WebCore/ChangeLog:43
> +	   (WebCore::Decimal::remainder):
> +	   Fix a bug in case that the fractional part of quotient is >= 0.5.
Also
> +	   make this matches to C99, C++11, ECMAScript behavior.

The change looks sane, but won't it affect something else?


More information about the webkit-reviews mailing list