[webkit-reviews] review granted: [Bug 102041] Enable datalist UI for input types week and month : [Attachment 173825] Patch

[bugzilla-daemon at webkit.org]

Kent Tamura <tkent at chromium.org> has granted Keishi Hattori
<keishi at webkit.org>'s request for review:
Bug 102041: Enable datalist UI for input types week and month
https://bugs.webkit.org/show_bug.cgi?id=102041

Attachment 173825: Patch
https://bugs.webkit.org/attachment.cgi?id=173825&action=review

------- Additional Comments from Kent Tamura <tkent at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=173825&action=review


> Source/WebKit/chromium/src/DateTimeChooserImpl.cpp:159
> +	   String otherDateLabelString;
> +	   if (m_parameters.type == WebCore::InputTypeNames::month())
> +	       otherDateLabelString =
Platform::current()->queryLocalizedString(WebLocalizedString::OtherMonthLabel);

> +	   else if (m_parameters.type == WebCore::InputTypeNames::week())
> +	       otherDateLabelString =
Platform::current()->queryLocalizedString(WebLocalizedString::OtherWeekLabel);
> +	   else
> +	       otherDateLabelString =
Platform::current()->queryLocalizedString(WebLocalizedString::OtherDateLabel);

nit: We have two instances of m_parameters.type checks in this function. We had
better merge them into one.