[webkit-reviews] review denied: [Bug 102000] [EFL][WK2] White flicker when scrolling big pages with dark background on slower hardware. : [Attachment 173814] Send color info directly to LayerTreeRenderer .

[bugzilla-daemon at webkit.org]

Noam Rosenthal <noam.rosenthal at nokia.com> has denied Viatcheslav Ostapenko
<ostap73 at gmail.com>'s request for review:
Bug 102000: [EFL][WK2] White flicker when scrolling big pages with dark
background on slower hardware.
https://bugs.webkit.org/show_bug.cgi?id=102000

Attachment 173814: Send color info directly to LayerTreeRenderer .
https://bugs.webkit.org/attachment.cgi?id=173814&action=review

------- Additional Comments from Noam Rosenthal <noam.rosenthal at nokia.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=173814&action=review


This will not work with semi-transparent backgrounds or with non rectangular
clip, as it uses glClear and friends which completely clear the pixels in a
given rectangle.
I suggest that instead of this we expose backgroundColor from DrawingAreaProxy,
and let the embedded (ewk_view?) decide what and how to clear.

> Source/WebKit2/UIProcess/CoordinatedGraphics/LayerTreeRenderer.cpp:96
> +    , m_backgroundColor(255, 255, 255, 255)

Color::white()

>
Source/WebKit2/WebProcess/WebPage/CoordinatedGraphics/LayerTreeCoordinator.cpp:
768
> +   
m_webPage->send(Messages::LayerTreeCoordinatorProxy::SetBackgroundColor(color))
;

So we do this on every layout? seems wasteful. Maybe we should make sure that
the color has actually changed?

> Source/WebKit2/WebProcess/WebPage/WebPage.cpp:2770
> +	   WebCore::Color color = WebCore::Color(float(red), float(green),
float(blue), float(alpha));

Color color(red, green, blue, alpha);