[webkit-reviews] review granted: [Bug 102043] Coordinated Graphics: Directly composited animated GIFs only render the first image. : [Attachment 173809] Patch

[bugzilla-daemon at webkit.org]

Noam Rosenthal <noam.rosenthal at nokia.com> has granted Huang Dongsung
<luxtella at company100.net>'s request for review:
Bug 102043: Coordinated Graphics: Directly composited animated GIFs only render
the first image.
https://bugs.webkit.org/show_bug.cgi?id=102043

Attachment 173809: Patch
https://bugs.webkit.org/attachment.cgi?id=173809&action=review

------- Additional Comments from Noam Rosenthal <noam.rosenthal at nokia.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=173809&action=review


Nice! Some rewording suggestions, otherwise good.

> Source/WebKit2/ChangeLog:14
> +	   In addition, handling a composited image is not the similar style of
handling a
> +	   layer state, filters, animations and etc. This patch fits handling a
composited
> +	   image to others.

In addition, this patch modifies the style of direct image compositing code to
match other parts of CoordinatedGraphicsLayer.

>
Source/WebKit2/WebProcess/WebPage/CoordinatedGraphics/CoordinatedGraphicsLayer.
cpp:357
> +	   // Make the decision about whether the image has changed.

This line is not needed.