[webkit-reviews] review granted: [Bug 102025] Web Inspector: [WK1]: Add a dock button to the top right corner of the window : [Attachment 173783] Proposed Change

[bugzilla-daemon at webkit.org]

Joseph Pecoraro <joepeck at webkit.org> has granted Timothy Hatcher
<timothy at apple.com>'s request for review:
Bug 102025: Web Inspector: [WK1]: Add a dock button to the top right corner of
the window
https://bugs.webkit.org/show_bug.cgi?id=102025

Attachment 173783: Proposed Change
https://bugs.webkit.org/attachment.cgi?id=173783&action=review

------- Additional Comments from Joseph Pecoraro <joepeck at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=173783&action=review


> Source/WebKit/mac/WebCoreSupport/WebInspectorClient.mm:72
> +- (NSCursor *)_cursorForResizeDirection:(NSInteger)direction {
> +    // Don't show a resize cursor for the northeast (top right) direction if
the dock button is visible.
> +    // This matches what happens when the full screen button is visible.
> +    if (direction == 1 && ![_dockButton.get() isHidden])

Same comments as Anders on the WK2 patch. Newline before the "{" and the .get()
isn't necessary on direct RetainPtr<> messages anymore.

> Source/WebKit/mac/WebCoreSupport/WebInspectorClient.mm:396
> +    // Get the frame view, the usperview of the content view, and its frame.


Nit (typo): "usperview" => "superview"