[webkit-reviews] review granted: [Bug 102023] Web Inspector: [WK2]: Add a dock button to the top right corner of the window : [Attachment 173779] Proposed Change

[bugzilla-daemon at webkit.org]

Anders Carlsson <andersca at apple.com> has granted Timothy Hatcher
<timothy at apple.com>'s request for review:
Bug 102023: Web Inspector: [WK2]: Add a dock button to the top right corner of
the window
https://bugs.webkit.org/show_bug.cgi?id=102023

Attachment 173779: Proposed Change
https://bugs.webkit.org/attachment.cgi?id=173779&action=review

------- Additional Comments from Anders Carlsson <andersca at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=173779&action=review


> Source/WebKit2/UIProcess/mac/WebInspectorProxyMac.mm:140
> +- (NSCursor *)_cursorForResizeDirection:(NSInteger)direction {

Newline before {

> Source/WebKit2/UIProcess/mac/WebInspectorProxyMac.mm:144
> +    if (direction == 1 && ![_dockButton.get() isHidden])
> +	   return nil;

You don't need the .get() here.