[webkit-reviews] review denied: [Bug 101932] [V8] Remove LIKELY()/UNLIKELY() from V8 binding cpp files : [Attachment 173631] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Nov 12 17:35:46 PST 2012


Kentaro Hara <haraken at chromium.org> has denied Kentaro Hara
<haraken at chromium.org>'s request for review:
Bug 101932: [V8] Remove LIKELY()/UNLIKELY() from V8 binding cpp files
https://bugs.webkit.org/show_bug.cgi?id=101932

Attachment 173631: Patch
https://bugs.webkit.org/attachment.cgi?id=173631&action=review

------- Additional Comments from Kentaro Hara <haraken at chromium.org>
> Have you run any performance tests to verify that these aren't needed?

I should do it. I was just blindly believing that LIKELY/UNLIKELY would be
meaningful in a part of inlined functions in headers.


More information about the webkit-reviews mailing list