[webkit-reviews] review granted: [Bug 102016] The act of getting the callee during 'this' construction should be explicit in bytecode : [Attachment 173768] the patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Nov 12 17:29:03 PST 2012


Michael Saboff <msaboff at apple.com> has granted Filip Pizlo <fpizlo at apple.com>'s
request for review:
Bug 102016: The act of getting the callee during 'this' construction should be
explicit in bytecode
https://bugs.webkit.org/show_bug.cgi?id=102016

Attachment 173768: the patch
https://bugs.webkit.org/attachment.cgi?id=173768&action=review

------- Additional Comments from Michael Saboff <msaboff at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=173768&action=review


r=me

> Source/JavaScriptCore/dfg/DFGByteCodeParser.cpp:-2127
> -	       set(currentInstruction[1].u.operand, addToGraph(CreateThis,
get(JSStack::Callee)));

Check and remove other magic from get(JSStack::Callee) prior change.


More information about the webkit-reviews mailing list