[webkit-reviews] review granted: [Bug 101978] Web Inspector: Fix docking behaviour on Windows. : [Attachment 173746] revised patch

[bugzilla-daemon at webkit.org]

Brian Weinstein <bweinstein at apple.com> has granted Roger Fong
<roger_fong at apple.com>'s request for review:
Bug 101978: Web Inspector: Fix docking behaviour on Windows.
https://bugs.webkit.org/show_bug.cgi?id=101978

Attachment 173746: revised patch
https://bugs.webkit.org/attachment.cgi?id=173746&action=review

------- Additional Comments from Brian Weinstein <bweinstein at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=173746&action=review


> Source/WebCore/inspector/InspectorFrontendClientLocal.cpp:143
> +    // Call setDockingUnavailable before bringToFront. If we display the
inspector window via bringToFront first it causes the call to canAttachWindow
to return the wrong result.

Another sentence on why this is the case would be helpful.

> Source/WebKit/win/ChangeLog:15
> +	   (WebInspectorFrontendClient::frontendLoaded):
> +	   (WebInspectorFrontendClient::attachWindow):

A high level comment about the changes in these functions would nice for people
reading the ChangeLog later.

> Source/WebKit/win/WebCoreSupport/WebInspectorClient.cpp:299
> +    // Immediately after calling showWindowWithoutNotifications(), the
parent frameview's visibleHeight incorrectly returns 0 always.

Is this a WebKit bug or a Windows bug?