[webkit-reviews] review denied: [Bug 101683] Should isViewSource checks in ScriptController::executeIfJavaScriptURL and ScriptController::canExecuteScripts be merged? : [Attachment 173563] Patch

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has denied Mike West <mkwst at chromium.org>'s
request for review:
Bug 101683: Should isViewSource checks in
ScriptController::executeIfJavaScriptURL and
ScriptController::canExecuteScripts be merged?
https://bugs.webkit.org/show_bug.cgi?id=101683

Attachment 173563: Patch
https://bugs.webkit.org/attachment.cgi?id=173563&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
So, this does the wrong thing for view-source documents.  It's too bad we don't
have a test for that.  (We should add one.)

Notice that ScriptController::canExecuteScripts returns true when isViewSource,
but executeIfJavaScriptURL used to abort execution if inViewSourceMode