[webkit-reviews] review denied: [Bug 101978] Web Inspector: Fix docking behaviour on Windows. : [Attachment 173710] patch

[bugzilla-daemon at webkit.org]

Brian Weinstein <bweinstein at apple.com> has denied Roger Fong
<roger_fong at apple.com>'s request for review:
Bug 101978: Web Inspector: Fix docking behaviour on Windows.
https://bugs.webkit.org/show_bug.cgi?id=101978

Attachment 173710: patch
https://bugs.webkit.org/attachment.cgi?id=173710&action=review

------- Additional Comments from Brian Weinstein <bweinstein at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=173710&action=review


I'd like to see one more version with Tim's comments and mine addressed. Patch
looks good though.

> Source/WebKit/win/ChangeLog:4
> +	   https://bugs.webkit.org/show_bug.cgi?id=100000

100000!!!

> Source/WebKit/win/WebCoreSupport/WebInspectorClient.cpp:258
> +	   restoreAttachedWindowHeight();

A comment explaining why we are restoring the attached window height before
attaching would be nice.

>> Source/WebKit/win/WebCoreSupport/WebInspectorClient.cpp:297
>> +	// Make sure that m_attached is true so that setAttachedWindowHeight
succeeds.
> 
> s/succeeds/doesn't return early/?

Should this say restoreAttachedWindowHeight instead of setAttachedWindowHeight?