[webkit-reviews] review canceled: [Bug 101649] m_columnLogicalWidthChanged is manipulating uninitialized memory : [Attachment 173134] Proposed memory fix: initialize m_columnPos.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Nov 12 14:15:10 PST 2012


Julien Chaffraix <jchaffraix at webkit.org> has canceled Julien Chaffraix
<jchaffraix at webkit.org>'s request for review:
Bug 101649: m_columnLogicalWidthChanged is manipulating uninitialized memory
https://bugs.webkit.org/show_bug.cgi?id=101649

Attachment 173134: Proposed memory fix: initialize m_columnPos.
https://bugs.webkit.org/attachment.cgi?id=173134&action=review

------- Additional Comments from Julien Chaffraix <jchaffraix at webkit.org>
(In reply to comment #6)
> (From update of attachment 173134 [details])
> I'm confused how this is covered by existing tests?  This only shows up in
valgrind?

This bug only shows up under Valgrind. What I meant is that it reproduces with
our existing tests so we don't need extra testing.

Clearing the review flag until I can explore the initialize POD by default
option. Note that this patch avoids the issue but may not be as generalized as
it could.


More information about the webkit-reviews mailing list