[webkit-reviews] review denied: [Bug 101967] [BlackBerry] Ensure we only receive one KeyUp per key event : [Attachment 173694] Patch

[bugzilla-daemon at webkit.org]

Rob Buis <rwlbuis at gmail.com> has denied Nima Ghanavatian
<nima.ghanavatian at gmail.com>'s request for review:
Bug 101967: [BlackBerry] Ensure we only receive one KeyUp per key event
https://bugs.webkit.org/show_bug.cgi?id=101967

Attachment 173694: Patch
https://bugs.webkit.org/attachment.cgi?id=173694&action=review

------- Additional Comments from Rob Buis <rwlbuis at gmail.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=173694&action=review


Looks good in general, some issues to be cleared up.

> Source/WebKit/blackberry/WebKitSupport/InputHandler.cpp:1589
> +	   if (m_expectedKeyUpChar == keyboardEvent.character() ||
(WTF::isASCIIUpper(m_expectedKeyUpChar) && m_expectedKeyUpChar ==
WTF::toASCIIUpper(keyboardEvent.character()))) {

You should not need the WTF:: prefix.

> Source/WebKit/blackberry/WebKitSupport/InputHandler.h:241
> +    short unsigned int m_expectedKeyUpChar;

What type do you want? This does not seem right.