[webkit-reviews] review granted: [Bug 101930] [EFL][WK2] Add --device-pixel-ratio command line option to EFL MiniBrowser : [Attachment 173655] patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Nov 12 11:32:03 PST 2012


Kenneth Rohde Christiansen <kenneth at webkit.org> has granted Mikhail Pozdnyakov
<mikhail.pozdnyakov at intel.com>'s request for review:
Bug 101930: [EFL][WK2] Add --device-pixel-ratio command line option to EFL
MiniBrowser
https://bugs.webkit.org/show_bug.cgi?id=101930

Attachment 173655: patch
https://bugs.webkit.org/attachment.cgi?id=173655&action=review

------- Additional Comments from Kenneth Rohde Christiansen
<kenneth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=173655&action=review


>>> Tools/MiniBrowser/efl/main.c:46
>>> +static double device_pixel_ratio = 0;
>> 
>> why not just use 1?
> 
> It's already has default value in Webkit. Don't want to set
customDeviceScaleFactor if it's not required by the User.

Such a comment might be good?


More information about the webkit-reviews mailing list