[webkit-reviews] review denied: [Bug 96614] Need to clear exception in JSDictionary for operations that might have. : [Attachment 173540] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has denied Charles Wei
<charles.wei at torchmobile.com.cn>'s request for review:
Bug 96614: Need to clear exception in JSDictionary for operations that might
have.
https://bugs.webkit.org/show_bug.cgi?id=96614

Attachment 173540: Patch
https://bugs.webkit.org/attachment.cgi?id=173540&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=173540&action=review


> Source/WebCore/bindings/js/JSDictionary.cpp:56
> +    if (m_exec->hadException()) // Clear exceptions, if any, left by last
query.
> +	   m_exec->clearException();

This is just the same change as before. This is not the correct idiom for use
of exceptions in the JavaScriptCore ExecState. What’s really going on here? We
need to get to the heart of the problem and fix that, not just clear an
exception in an ExecState in one particular binding.